remove UNKNOWN tag from ami dropdown #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalii-honchar
previously approved these changes
Mar 6, 2024
|
as you are here, can you change [GOLDEN] -> [CURRENT_GOLDEN], also check if we can have other old golden amis have tag [GOLDEN] |
done 👍
@ntascii this should be possible though we might want to make a new endpoint in rodimus for getting all golden ami id's given a cell + name to make it more performant. It looks like with the currently existing endpoints we would have to get the tags for each base image in the dropdown, which would be ~100 api calls on page load. I'm thinking of leaving this for another PR. |
ntascii
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove UNKNOWN status in AMI dropdown